slapd crashes due to assertion failure

[John Morrissey <jwm@horde.net>]

We recently upgraded from 2.3.30 to 2.3.41. Ever since, slapd has died about
once a week due to an assertion failure. A backtrace is below, but I forgot
to disable optimization in the build, so there's been some inlining.

The only assertions in connection_close() are:

    assert( connections != NULL );
    assert( c != NULL );
[...]
    assert( c->c_struct_state == SLAP_C_USED );
    assert( c->c_conn_state == SLAP_C_CLOSING );

I'm not sure if this gives enough to go on, but I've rebuilt with
optimization disabled and have a debugger attached for the next time it
fails.

Program received signal SIGABRT, Aborted.
[Switching to Thread -1884128336 (LWP 26138)]
0xb7b98947 in raise () from /lib/tls/libc.so.6
#0  0xb7b98947 in raise () from /lib/tls/libc.so.6
#1  0xb7b9a0c9 in abort () from /lib/tls/libc.so.6
#2  0xb7b9205f in __assert_fail () from /lib/tls/libc.so.6
#3  0x0806d052 in connection_close (c=<value optimized out>)
    at /var/jwm/openldap/servers/slapd/connection.c:680
#4  0x0806d67d in connection_operation (ctx=0x8fb272c8, arg_v=0x993a830)
    at /var/jwm/openldap/servers/slapd/connection.c:1722
#5  0xb7f14e7f in ldap_int_thread_pool_wrapper (xpool=0x814d358)
    at /var/jwm/openldap/libraries/libldap_r/tpool.c:478
#6  0xb7ca70bd in start_thread () from /lib/tls/libpthread.so.0
#7  0xb7c3c01e in clone () from /lib/tls/libc.so.6

john
-- 
John Morrissey          _o            /\         ----  __o
jwm@horde.net        _-< \_          /  \       ----  <  \,
www.horde.net/    __(_)/_(_)________/    \_______(_) /_(_)__