Some code suggestions...

[Emmanuel Lecharny <elecharny@apache.org>]

Hi Shawn,

I will use this mailing list for comments, suggestions and questions
regarding the code base, so that it will benefit to everyone interested.

I have a couple of suggestions I already mentionned in a chat, but it's
better to have them recorded here :

1) You may want ot use the LDAP connection pool to replace the pool you
are using. Mots of the LDAP API has an implementation of a pool, even
JNDI (but you don't want to suffer using it , do you ?)

2) It would be better to get the connection immediately before using it,
and to release it as soon as you are done with it. For instance, the
connection could be get just before calling the dataProvider and
released just after. Not really a huge improvment, but assuming that
you may have thousands of requests per second, this may become an
issue.

Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com