Re: commit: ldap/servers/slapd/overlays sssvlv.c

[masarati@aero.polimi.it]

> ando@OpenLDAP.org wrote:
>> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/overlays
>>
>> Modified Files:
>> 	sssvlv.c  1.18 ->  1.19
>>
>> Log Message:
>> make sure so is correctly initialized (spotted by valgrind, possibly
>> related to ITS#6649)
>
> This patch ought to have no visible effect, since all relevant sort_op
> fields
> are initialized as needed in lines 815-834. Where does valgrind say any
> misuse
> occurs?

sssvlv.c:556 when checking whether this value is set.  Actually, I could
crash slapd 2.4.23 by issuing a search with sort and paged results, since
so_vlv uninitialized would make that condition true while it ought to be
false.  With valgrind it does not fail (I assume valgrind considers the
uninitialized value == 0) but the missing initialization is correctly
detected.

p.