Re: commit: ldap/servers/slapd bconfig.c

[Ralf Haferkamp <rhafer@suse.de>]

Hm, seems that this mail didn't get through on the first attempt. At least I 
didn't see it on openldap-devel. Next try ...

On Thursday 29 March 2007 17:45, Howard Chu wrote:
> ralf@OpenLDAP.org wrote:
> > Update of /repo/OpenLDAP/pkg/ldap/servers/slapd
> >
> > Modified Files:
> > 	bconfig.c  1.267 -> 1.268
> >
> > Log Message:
> > Add operational Attributes when creating frontend and config database
> > entries. (Otherwise test049-sync-config fails)
> >
> >
> > CVS Web URLs:
> >   http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/
> >     http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/bconfig.c
> >
> > Changes are generally available on cvs.openldap.org (and CVSweb)
> > within 30 minutes of being committed.
> > .
> Most of the code in this checkin is a duplicate of slap_add_opattrs().
Actually I was looking at the slapadd() function in slapadd.c while 
implementing this. Didn't really have slap_add_opattrs() in mind then :|.

> Any reason you didn't use that?
While looking at slap_add_opattrs() I am bit unsure if that can really be used 
in that place (during slapadd). It would at least need a correctly 
initialized Operation* and Connection* structure. But I can give it a try.

If that works. I guess it would make sense to also change the code in 
slapadd() to use slap_add_opattrs() as well?

-- 
Ralf