Re: commit: ldap/servers/slapd/overlays syncprov.c

[Howard Chu <hyc@symas.com>]

ando@OpenLDAP.org wrote:
> Update of /repo/OpenLDAP/pkg/ldap/servers/slapd/overlays
>
> Modified Files:
> 	syncprov.c  1.133 -> 1.134
>
> Log Message:
> rework previous commit?
>
> CVS Web URLs:
>   http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/overlays/
>     http://www.openldap.org/devel/cvsweb.cgi/servers/slapd/overlays/syncprov.c
>
> Changes are generally available on cvs.openldap.org (and CVSweb)
> within 30 minutes of being committed.
>
>   
I'm not sure this makes sense. If you're going to generate the CSN, then 
there's no reason to do the search at all. I.e., assuming the server's 
clock hasn't been reset, the generated CSN will always be newer than 
anything already in the database.

Again, the original code does a search to find the greatest entryCSN in 
the DB. It may not be crucial to get this value for a database that has 
never been contacted by any consumers yet, so just generating when 
si_ctxcsn is empty may be fine.

--
 -- Howard Chu
 Chief Architect, Symas Corp.  http://www.symas.com
 Director, Highland Sun        http://highlandsun.com/hyc
 OpenLDAP Core Team            http://www.openldap.org/project/