[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: commit: ldap/clients/tools ldapsearch.c



> At 12:09 AM 6/18/2004, Pierangelo Masarati wrote:
>
>>> Log Message:
>>> Fix a limit typo
>>> Use 0 not maxint when 'none' is selected.
>>
>>this was intended as a means to provide a helper to hit the hard instead
>>of the soft limits.  See ITS#3136 for a background.  In fact, if one sets
>>size.soft=100 size,hard=unlimited, then, to hit the unlimited case one
>>needs to require a size limit.  There is no notion of unlimited size in
>>the client library, nor in the protocol, so my idea was to use the max
>>integer allowed by the protocol, and add a shortcut string in ldapsearch
>>-z, -l to hit this value.  Maybe a different keyword would be better,
>> e.g.
>>"unlimited".
>
> Well, from a protocol perspective, 0 means no limit (e.g., unlimited).

"unlimited" and "no limit explicitly requested" is rather different;
currently, we interpret 0 as "no limit explicitly requested", resulting in
soft limits being used.  This is the interpretation slapd currently uses.

>
> I think what you're trying to do is not to hit the "unlimited
> case" but to hit the hard limit.
>
> Maybe add a "max" case which means maxInt.
>
>>Otherwise one has to manually specify the largest value atoi
>>(now strtol) can accept.
>
> Seems approproriate.

OK.

p.

-- 
Pierangelo Masarati
mailto:pierangelo.masarati@sys-net.it


    SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax: +390382476497