[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7271) Don't clobber SASL_NOCANON in clients/tools/common.c

W. Trevor King wrote:
> On Wed, May 30, 2012 at 06:14:38AM -0700, Howard Chu wrote:
>> Ideally the command line option should have been able to set this
>> explicitly to both true and false, to allow complete control over
>> the option. But I'm not particularly concerned either way. Since the
>> option currently can only be set to true, it would be sufficient to
>> just check for nocanon != 0 before calling ldap_set_option.
>
> My personal goal here is to not need to bother with command line
> options, so I'm fine with this less general solution.  Another patch
> (only set the option with an explicit `-N`) attached.
>
> ---
> The attached patch file is derived from OpenLDAP Software. All of the
> modifications to OpenLDAP Software represented in the following
> patch(es) were developed by W. Trevor King wking@tremily.us. I have
> not assigned rights and/or interest in this work to any party.
>
> I, W. Trevor King, hereby place the following modifications to
> OpenLDAP Software (and only these modifications) into the public
> domain. Hence, these modifications may be freely used and/or
> redistributed for any purpose with or without attribution and/or other
> notice.
>
Thanks, added to master.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/