[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#7054) Please drop support to FreeBSD 1.x

delphij@FreeBSD.org wrote:
> Full_Name: Xin Li
> Version: git trunk
> OS: FreeBSD/amd64 10.1
> URL: http://pastebin.com/G8gpJs0r
> Submission from: (NULL) (206.40.55.65)
>
>
> Code duplicated from GNU libtool and autotools uses 'freebsd1*' rather than
> 'freebsd1.*' to test if the system is FreeBSD 1.x.  This logic would match
> FreeBSD 10.0, causing problem when building shared libraries.
>
> I'd like to propose that FreeBSD 1.x support be dropped since it's obsolete in
> 1994 (17 years ago).

Probably a good idea. Thanks for the patch, but it's basically unusable.

Never submit patches to generated files. Only patch the source files. 
configure is generated from configure.in by autoconf. aclocal.m4 is also 
generated by autoconf; the section you patched appears to come from the 
libtool sources.

> The patch is just for reference, it also drops FreeBSD 2.x and FreeBSD 3.x
> support but it's not complete.
>
> A libtool patched with git revision e94c6d6e0359d92f08f491f57e0ef3371e978952
> would also be required to build OpenLDAP properly.
>
>


-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/