[Date Prev][Date Next]
[Chronological]
[Thread]
[Top]
Re: (ITS#6721) uninitialized timeout in back-ldap
h.b.furuseth@usit.uio.no wrote:
> Full_Name: Hallvard B Furuseth
> Version: 4.2.19 - 4.2.23
> OS:
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (129.240.6.233)
> Submitted by: hallvard
>
>
> ITS#6282 introduced
> struct timeval tv;
> tv.tv_sec = -1;
> in back-ldap: extended.c and config.c. This leaves tv_usec uninitialized
> and the timeout possibly positive. Fixing to:
> struct timeval tv = { -1, 0 };
>
The way I read the code (at the time of the ITS#6282) if tv_sec < 0 no
timeout was used. In any case, your fix is fine for me.
p.