Re: (ITS#6645) Yet Another LDIF Wrap Patch

[hyc@symas.com]

masarati@aero.polimi.it wrote:
> Full_Name: Pierangelo Masarati
> Version: HEAD/re24
> OS: irrelevant
> URL: ftp://ftp.openldap.org/incoming/pierangelo-masarati-2010-09-09-ldif-wrap.1.patch
> Submission from: (NULL) (129.72.165.135)
> Submitted by: ando
>
>
> The subject should be self-explanatory.  It is only exploited by slapcat, via
> the -o ldif-wrap=<n>  option (<n>  <  0: default;<n>  == 0: no wrap;<n>  >  0: wrap
> value); extending ldapsearch is trivial.
>
> I'm *NOT* going to commit this unless there is unanimous consensus ;)

Not thrilled with the magic constant 2^31-1. Seems like you should have just 
used "if ( wrap && len > wrap )" instead of a word-size-dependent magic.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/