[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#6225) GSSAPI support for client library (fixes)



--LZvS9be/3tNcYl/X
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Howard,

On Fri, Jul 24, 2009 at 09:20:46PM -0700, Howard Chu wrote:
> mimir@samba.org wrote:
> >Full_Name: Rafal Szczesniak
> >Version: Stable (2.4.16)
> >OS: GNU/Linux
> >URL: http://www.samba.org/~mimir/gssapi-bugfix.diff
> >Submission from: (NULL) (67.51.54.234)
> >
> >
> >This is a bugfix patch for OpenLDAP's gssapi support.
> >
> One of these patches appears to duplicate ITS#6092. As the original
> author of this code, could you also take a look at #6091 and #6093?

I'm really sorry but after I looked at current code in HEAD and I thought I=
 liked it
(the actual issue was fixed), following with this thread completely went of=
f my radar.
I've found it while looking through my mailbox.

The last chunk of this its' patch still applies though. It's a minor thing =
but fixes
potential memory leak. I can open a separate ITS for it if you like.

As for the other patches - #6091 is (was) convenient but not absolutely nec=
essary
and #6093 is interesting but I'm not sure if it isn's a bit too much. If yo=
u're connecting
invalid (from kerberos point of view) hostname then, well, find out what's =
the correct=20
hostname first.

This its # can be closed of course.


cheers,
--=20
Rafal Szczesniak
Samba Team member   http://www.samba.org
Likewise Software   http://www.likewise.com


--LZvS9be/3tNcYl/X
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLy1e3Hvdfyv3qiKkRAk7ZAJ0VPkzc89VAxXh/AF4EZVCJTvS/fgCfeZK7
TULoTjp8aXQkK0oGZNShxsY=
=zucU
-----END PGP SIGNATURE-----

--LZvS9be/3tNcYl/X--