[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5903) memberof stacked instance member-attr delete failure



hyc@symas.com wrote:
> mbackes@symas.com wrote:
>> Full_Name: Matthew Backes
>> Version: 2.4, head
>> OS: any
>> URL:
>> Submission from: (NULL) (76.88.99.93)
>>
>>
>> If slapo-memberof is instanced more than once, deleting the
>> member-attr values from a group or deleting the group object will not
>> remove the memberof-attr values from the members.
>>
>> Adds are not affected.
>>
>> Internally, the operation fails because it tries using the
>> memberof-attribute name from the last memberof instance in the stack.
> 
> The memberOf code is using a single static variable to hold its state. This is 
> obviously broken. It's also using thread keys for its temporary storage, which 
> is totally unnecessary; it should simply use its own callback and the 
> cb_private field of that callback. As such, much of this code needs to be 
> gutted and rewritten.

See also ITS#5654.

p.


Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
-----------------------------------
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Fax:     +39 0382 476497
Email:   ando@sys-net.it
-----------------------------------