[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5804) attribute value regex expantion



quanah@zimbra.com wrote:
> --On November 28, 2008 9:07:49 PM +0000 quanah@zimbra.com wrote:
> 
>>
>> --On November 28, 2008 9:02:27 PM +0000 manu@netbsd.org wrote:
>>
>>> Konstantinos Koukopoulos <kouk@noc.edunet.gr> wrote:
>>>
>>>> Turns out 'val' is nil and it doesn't seem like there's any check for
>>>> that. Maybe naive fix:
>>> I see Ando committed it. But there are many other locations in the file
>>> where acl_string_expand is called with an unchecked val->bv_val. It
>>> seems these also need to be fixed, but I miaght be missing a point.
>> IIRC, this also broke ACI's in RE2.4, and that still needs fixing as well.
> 
> Egh, in HEAD only, I mean, as this wasn't applied yet to RE24.

:)  I've reworked the use of string expansion (and lined up regex 
expansion in "by" dn).  In order to fix ACIs, the dynacl API needs to be 
enhanced to support AclRegexMatches.

p.


Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
-----------------------------------
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Fax:     +39 0382 476497
Email:   ando@sys-net.it
-----------------------------------