Re: (ITS#5734) Serch limits by baseDN

[ando@sys-net.it]

h.b.furuseth@usit.uio.no wrote:
> I wrote:
>> Here a suggested patch, currently a quick hack for inspection.
> 
> I forgot slap.h.  Added it now.  And manpage while I'm at it.
> 
>> This needs an API change: Currently slapd/limits.c:limits_gets()
>> takes the bound DN as an argument.  The change needs a function
>> which fetches the bound or examined DN from the Operation structure.
> 
> Typo, it's                             slapd/limits.c:limits_get()
> 
>> Is it OK to just remove the DN argument and make the function
>> static, so any existing binaries that call it won't silently get
>> the changed API?  Slapd doesn't call this function anywhere.
> 
> ..it's not called anywhere _else_, that is.

Sounds good for me.

p.


Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
-----------------------------------
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Fax:     +39 0382 476497
Email:   ando@sys-net.it
-----------------------------------