[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: (ITS#5540) Normalization assertion in attr.c



Hi,

On Sat, Jun 28, 2008 at 7:47 PM, Howard Chu <hyc@symas.com> wrote:
> Howard Chu wrote:
>> unix.gurus@gmail.com wrote:
>>> If someone wants to accept or comment on what needs fixing in the
>>> patch below, that would help me to generate the rest of the patches:
>>>
>>> ftp://ftp.openldap.org/incoming/sean-burford-monitor-normalize-unified-080624.patch
>>
>> In back-monitor/database.c you don't need to normalize the DNs before
>> comparing them. The stored values are already Prettied, so all you need is
>> to
>> use a case-insensitive compare here.
>
> Duh. Or just compare a->a_vals and be->be_suffix instead.

Good point.  I've uploaded the following patch which does that as well
as adding matching rules to configContext and monitorContext:
ftp://ftp.openldap.org/sean-burford-monitor-normalize-unified-080706.patch

This patch should make the handling of normalization within cn=monitor
consistent.

-- 
Thanks,
Sean Burford