[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: Issues with syncrepl and mirrormode



Pierangelo Masarati wrote:
Pierangelo Masarati wrote:
Mi first question is: is "rid=004,sid=000,csn=" a legitimate cookie?
As far as our implementation goes, no. slap_compose_sync_cookie() should
never
produce this.

I could reproduce it, but unfortunately I don't have much info available. I have instrumented syncprov.c to log the cookie any time it is prepared,
and the incorrect cookie was generated by slap_compose_sync_cookie() when
invoked by syncprov_sendresp() after a successful add. I only saw the
log, so I couldn't inspect memory during that operation, so I'm trying to
narrow things down to a small and quickly reproducible example. Apparently, opc->sctxcsn contains an empty berval, otherwise no "csn="
portion would apprear in the cookie.

This sounds like we're being bitten by the conversion of the original BER_BVISEMPTY checks to BER_BVISNULL. As I noted at that time, this was probably going to break.
--
-- Howard Chu
Chief Architect, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/