Re: (ITS#5108) SID/RID: decimal or hex?

[ando@sys-net.it]

Howard Chu wrote:
> ando@sys-net.it wrote:
>> Full_Name: Pierangelo Masarati
>> Version: HEAD/re23
>> OS: irrelevant
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (82.63.140.131)
>> Submitted by: ando
>>
>>
>> Should SID/RID be decimal (0-999) as in parsing and the rest of the
>> syncrepl
>> code, or hexadecimal (0-FFF) as in code generating CSN values?  I
>> understand the
>> point is (almost) moot, but we'd get there as soon as someone starts
>> using
>>> 10-way multimaster...
>>
>> I'm fixing the code so that it consistently uses hex server IDs,
>> please holler
>> if using decimals is preferred.
> 
> The SID in the CSN has always been hex (but usually zero). The RID is
> not part of the CSN and has always been decimal. Since the RID only
> needs to be unique within a particular slapd instance, there's no real
> problem there.
> 

Right.  but, well, slap_parse_csn_sid() was using strtoul(..., 10).  Now
fixed.  For consistency I've made both behave the same.  The user won't
basically notice it, so I don't see backward compatibility issues.

p.



Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
---------------------------------------
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Email:   pierangelo.masarati@sys-net.it
---------------------------------------