(ITS#4990) memory debugging issues

[h.b.furuseth@usit.uio.no]

Full_Name: Hallvard B Furuseth
Version: HEAD, RE23
OS: 
URL: 
Submission from: (NULL) (129.240.202.105)
Submitted by: hallvard


CPPFLAGS=-DLDAP_MEMORY_DEBUG won't build: ber_int_meminuse is not defined.

sl_malloc.c needs s/ber_malloc_x/ber_memalloc_x/ under SLAP_NO_SL_MALLOC.

There are both #if and #ifdef LDAP_MEMORY_DEBUG statements, but value 0
breaks compilation.

LDAP_MEMORY_DEBUG enables a number of assert()s that break OpenLDAP
code, like ldap_control_free(NULL).  Until they are cleaned up (if
they are still considered errors) I'll disable them by default unless
LDAP_MEMORY_DEBUG & 2.  Could do the opposite if someone wants.

I'll insert LDAP_MEMORY_DEBUG code in slap_sl_malloc() as well (insert
memory signature before each returned chunk, check upon free/realloc).