Re: (ITS#4790) re23 hangs during shutdown after test033

[hyc@symas.com]

----  <ando@sys-net.it> wrote:
>
> Full_Name: Pierangelo Masarati
> Version: re23 (2.3.31)
> OS: Linux
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (87.28.220.33)
> 
> 
> Apparently, one thread is unable to terminate correctly, so the test succeeds,
> but then slapd hangs forever in ldap_pvt_thread_pool_destroy().  I couldn't
> investigate this in depth right now, but I could easily reproduce it on two
> different systems (different kernels and so), so I'm positive I can easily
> reproduce it.

This is a bad patch to connections_shutdown in RE23, there is a "continue" after checking for a client session that shouldn't be there. This line is not present in HEAD and the bug doesn't exist in HEAD. Strange that it got there since we just recently sync'd RE23 with HEAD's connection.c.

  -- Howard Chu
  Chief Architect, Symas Corp.       Director, 
Highland Sun
  http://www.symas.com               
http://highlandsun.com/hyc
  Symas: Premier OpenSource Development and 
Support