(ITS#4722) crash in daemon.c

[quanah@stanford.edu]

Full_Name: Quanah Gibson-Mount
Version: 2.3.27/HEAD
OS: Linux 2.6 (64-bit)
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (171.64.19.81)


With the latest updates, I hit a assert in daemon.c (from HEAD).  It appears
there is still a possible race condition.

The assert hit was:

daemon.c:551

        assert( SLAP_SOCK_IS_ACTIVE( s ));

in slapd_clr_write

called from:

connection.c:808

                        slapd_clr_write( sd, 1 );

in connection_closing

It looks like the write needs to be cleared before the mutex is unlocked.

--Quanah