Re: ITS#4338 (Was: commit: ldap/servers/slapd daemon.c)

[bgmilne@staff.telkomsa.net]

--nextPart3032165.IXWms83AAz
Content-Type: text/plain;
  charset="iso-8859-6"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Saturday 14 January 2006 11:45, Pierangelo Masarati wrote:
> On Fri, 2006-01-13 at 16:30 +0000, hyc@OpenLDAP.org wrote:
> > Update of /repo/OpenLDAP/pkg/ldap/servers/slapd
> >
> > Modified Files:
> > 	daemon.c  1.372 -> 1.373
> >
> > Log Message:
> > ITS#4338 delete extraneous slapd_close() calls. Descriptors that were in
> > the event set must be removed using slapd_remove() and the whole sequen=
ce
> > must be protected with the slap_daemon.sd_mutex to close them properly.
> > Otherwise it will wind up closing valid, freshly opened sockets, or
> > closing dead sockets twice, etc. It's unnecessary to do any close
> > management here since connection.c already does the correct teardown
> > sequence.
>
> I guess this answer obsoletes ITS#4333; based on some odd connection-
> closing related logging I get when test036 & test039 hung (proxy &
> targets perfectly responsive, but no activity on both and the clients
> waiting for response), I suspect this was the same root cause.


The behaviour I saw was different, but as #4338 may have triggered #4333, I=
'll=20
run the box in question under load for a day under the same conditions and=
=20
see if I can trigger it now.

Regards,
Buchan

=2D-=20
Buchan Milne
ISP Systems Specialist
B.Eng,RHCE(803004789010797),LPIC-2(LPI000074592)

--nextPart3032165.IXWms83AAz
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQBDy08UrJK6UGDSBKcRAjI6AJ0aMdCbXH7n/LKozeQg0ySQWhpUqACfQUJl
YLnultqZ9h60BptVPQyL3VI=
=UYPz
-----END PGP SIGNATURE-----

--nextPart3032165.IXWms83AAz--