Re: SLAPI (ITS#2073)

[somrani@us.ibm.com]

Ando, -- Thank you for looking  the code over. I will be making a new
submission within the next few days that correct some defects.  I am
suspecting the libtool warning comes from the fact I am linking static
libraries (it is more than just libtmpslapd.a) to produce dynamic library
(libslapi.so). I don not like the Warning either, however, in testing I did
not experience any problem. In our build environment, we do not see this
warning. Suggestions are welcome.


Thanks,

Steve Omrani
Senior Software Developer
Internet: somrani@us.ibm.com
Phone: 512-838-8375 (TL 678-8375)
Fax: 512-838-8597



                                                                                                                                      
                      "Pierangelo                                                                                                     
                      Masarati"                To:       Steve Omrani/Austin/IBM@IBMUS                                                
                      <ando@sys-net.it>        cc:       <openldap-its@openldap.org>                                                  
                                               Subject:  Re: SLAPI (ITS#2073)                                                         
                      11/04/2002 03:02                                                                                                
                      AM                                                                                                              
                      Please respond to                                                                                               
                      ando                                                                                                            
                                                                                                                                      
                                                                                                                                      



Steve,

I've uploaded a patch to

http://www.sys-net.it/~ando/Download/Pierangelo-Masarati-20021104-Steve-Omrani.ns_slapi_.diff


which includes the porting of your submission
to current HEAD code and some fixes.  Among these
you should carefully review "slapi_ops.c" because
there is a number of pointers that are used
uninitialized (significantly the pointer to the
Backend structure, "be"). Other fixes are related
to slapi API functions, like the (apparently)
inconsistent use of slapi_strlen()/slapi_ch_stlen()
(none of which is defined).  I also get very scary
warnings from libtool because you statically link
some libtmpslapd.a to libslapi (if I get it correctly)
in an unportable manner.

Note that I didn't check the functionality of SLAPI
itself (this will require a little more); I only
verified that I can compile OpenLDAP safely and
that the usual tests run OK.

In case you think my changes are appropriate, send
me a note (or a patch with further fixes) and I'll
commit everything.

Of course, any other comment or review is welcome
before I actually commit the patch.

Pierangelo.

--
Pierangelo Masarati
mailto:pierangelo.masarati@sys-net.it