buglets in slapd/back-monitor (ITS#1710)

[h.b.furuseth@usit.uio.no]

Full_Name: Hallvard B. Furuseth
Version: 2.1.0alpha
OS: Linux
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (158.36.148.34)


conn.c:monitor_subsys_conn_create() doesn't free the chain of mp's
it has created if it returns -1 and ndn == NULL.

log.c:monitor_subsys_log_modify() has some '#if 0'ed code which locks
op->o_abandonmutex but forgets to unlock it if o_abandon is not set.
Is that why that code is '#if 0'ed out - because it did not work?

BTW, is mp->mp_mutex locked when entering cache.c:monitor_cache_release()
with (mp_flags & MONITOR_F_VOLATILE)?  If so, it should be unlocked
before it is destroyed.  I can't tell; I lost track of how those mutexes
are used.