[Date Prev][Date Next] [Chronological] [Thread] [Top]

Re: Memory leak in ldap_first_attribute()? (ITS#1009)



Fixed in HEAD and OPENLDAP_REL_ENG_2, please test, thanks.
        Kurt

At 08:23 AM 2/2/01 +0000, tkemmer@hyperwave.com wrote:
>Full_Name: Thomas Kemmer
>Version: 2.0.7
>OS: Linux 2.x
>URL: ftp://ftp.openldap.org/incoming/
>Submission from: (NULL) (129.27.200.60)
>
>
>Hi all,
>
>when debugging an LDAP client with -DLDAP_MEMORY_TRACE, I stumbled over
>something
>that looks like a 44 byte memory leak that occurs sometimes in 
>ldap_first_attribute(). The suspicious code is in libraries/libldap/getattr.c, 
>around line 71:
>
>        if ( ber_pvt_ber_remaining( ber ) == 0 ) {
>                assert( len == 0 );
>                return NULL;
>        }
>
>Inserting a 
>
>                ber_free( ber, 0 );
>
>before the return statement seems to fix this problem.
>
>Since I'm not an expert with the inner workings of libldap, I'd ask you to
>confirm
>that this doesn't have any unwanted side-effects, please...