Re: Linking of slapd/tools (ITS#602)

[Kurt@OpenLDAP.org]

At 09:46 AM 6/21/00 GMT, Christian.Lorenz@suse.de wrote:
>Full_Name: Christian Lorenz
>Version: 2.0-devel
>OS: linux-2.2.14
>URL: ftp://ftp.openldap.org/incoming/
>Submission from: (NULL) (195.243.113.230)
>
>
>I suggest to only link those slapd/tools with the MODULE_LIBS which also
>link against the libbackend.a.
>I had problems with a backend that uses librecode: I confiured -lrecode
>into the MODULE_LIBS. The slapd itself builds fine, but ldif failed, because
>the global variable 'program_name' (which librecode depends on) was only
>defined in my backend!

If you disregard ldif, I believe MODULE_LIBS belongs on XXLIBS, not
XXXLIBS.  It certainly needs to come before LTHREAD_LIBS.

The obvious thing to do is move ldif to clients/tools.
But, then again, do we really need ldif(8) anymore?
ldapmodify(1) handles the -b case directly... and the
per line to base64 is infrequently used (I've never used
it).

I think we should:
	1) move ldif(1) to the Attic
	2) move MODULES_LIB
		a) to XXLIBS
		b) before LTHREAD_LIBS

Comments?
	Kurt


>Here's the patch:
>------------------------------------------------------------------------
>--- ldap/servers/slapd/tools/Makefile.in.orig   Tue Jun 13 15:05:48 2000
>+++ ldap/servers/slapd/tools/Makefile.in        Wed Jun 21 11:32:16 2000
>@@ -30,7 +30,7 @@
> XXLIBS = $(QUIPU_LIBS) $(SLAPD_LIBS) \
>        $(LDBM_LIBS) $(SECURITY_LIBS) \
>        $(LDIF_LIBS) $(LUTIL_LIBS)
>-XXXLIBS = $(LTHREAD_LIBS) $(MODULES_LIBS)
>+XXXLIBS = $(LTHREAD_LIBS)
> 
> PROGRAMS=ldif slappasswd slapadd slapcat slapindex
> LDBMPROGRAMS=centipede sizecount
>@@ -84,13 +84,13 @@
> # SLAP Tools
> #
> slapadd:       slapadd.o ../libbackends.a $(SLAPOBJS) $(SLAPD_LIBDEPEND) 
>-       $(LTLINK) -o $@ slapadd.o $(SLAPOBJS) ../libbackends.a $(LIBS)
>+       $(LTLINK) -o $@ slapadd.o $(SLAPOBJS) ../libbackends.a $(LIBS)
>$(MODULES_LIBS)
> 
> slapcat:       slapcat.o ../libbackends.a $(SLAPOBJS) $(SLAPD_LIBDEPEND) 
>-       $(LTLINK) -o $@ slapcat.o $(SLAPOBJS) ../libbackends.a $(LIBS)
>+       $(LTLINK) -o $@ slapcat.o $(SLAPOBJS) ../libbackends.a $(LIBS)
>$(MODULES_LIBS)
> 
> slapindex:     slapindex.o ../libbackends.a $(SLAPOBJS) $(SLAPD_LIBDEPEND) 
>-       $(LTLINK) -o $@ slapindex.o $(SLAPOBJS) ../libbackends.a $(LIBS)
>+       $(LTLINK) -o $@ slapindex.o $(SLAPOBJS) ../libbackends.a $(LIBS)
>$(MODULES_LIBS)
> 
> ldif:          ldif.o $(SLAPD_LIBDEPEND) 
>        $(LTLINK) -o $@ ldif.o $(LIBS)
>----------------------------------------------------------------------------
>
>Have fun!
>
>
>