Issue 8734 - Fixes for multiple back-asyncmeta issues
Summary: Fixes for multiple back-asyncmeta issues
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: 2.5.4
Hardware: All All
: --- normal
Target Milestone: 2.5.0
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-13 13:22 UTC by Nadezhda Ivanova
Modified: 2020-10-14 21:12 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Nadezhda Ivanova 2017-09-13 13:22:49 UTC
Full_Name: Nadezhda Ivanova
Version: 2.5
OS: 
URL: ftp://ftp.openldap.org/incoming/nadezhda-ivanova-170913.patch
Submission from: (NULL) (87.227.214.182)


This patch contains the fixes for all issues discovered and fixed since the
initial submission of back-asyncmeta. These include memory leaks, stability
issues, segfaults and functional bugs.

IPR:

The attached files are derived from OpenLDAP Software. All of the modifications
to OpenLDAP Software represented in the following patch were developed by Symas
Corporation. Symas Corporation has not assigned rights and/or interest in this
work to any party. I, Nadezhda Ivanova, am authorized by Symas Corporation, my
employer, to release this work under the following terms.

The attached modifications to OpenLDAP Software are subject to the following
notice:

Copyright 2017 Symas Corporation
Redistribution and use in source and binary forms, with or without
modification,
are permitted only as authorized by the OpenLDAP Public License.
Comment 1 Nadezhda Ivanova 2017-10-30 10:13:32 UTC
Hi,
A new version of the patch has been uploaded as
ftp://ftp.openldap.org/incoming/nadezhda-ivanova-171030.patch

It contains fixes to a couple of problems found after the initial submission:
1. A problem where asyncmeta could not proxy a request containing a \0 in the filter
2. An unnecessary and misleading log message, that logged the operation as timed out when it wasn't.

----- Original Message -----
From: "openldap-its" <openldap-its@OpenLDAP.org>
To: nivanova@symas.com
Sent: Wednesday, September 13, 2017 4:22:51 PM
Subject: Re: (ITS#8734) Fixes for multiple back-asyncmeta issues

*** THIS IS AN AUTOMATICALLY GENERATED REPLY ***

Thanks for your report to the OpenLDAP Issue Tracking System.  Your
report has been assigned the tracking number ITS#8734.

One of our support engineers will look at your report in due course.
Note that this may take some time because our support engineers
are volunteers.  They only work on OpenLDAP when they have spare
time.

If you need to provide additional information in regards to your
issue report, you may do so by replying to this message.  Note that
any mail sent to openldap-its@openldap.org with (ITS#8734)
in the subject will automatically be attached to the issue report.

	mailto:openldap-its@openldap.org?subject=(ITS#8734)

You may follow the progress of this report by loading the following
URL in a web browser:
    http://www.OpenLDAP.org/its/index.cgi?findid=8734

Please remember to retain your issue tracking number (ITS#8734)
on any further messages you send to us regarding this report.  If
you don't then you'll just waste our time and yours because we
won't be able to properly track the report.

Please note that the Issue Tracking System is not intended to
be used to seek help in the proper use of OpenLDAP Software.
Such requests will be closed.

OpenLDAP Software is user supported.
	http://www.OpenLDAP.org/support/

--------------
Copyright 1998-2007 The OpenLDAP Foundation, All Rights Reserved.

Comment 2 Nadezhda Ivanova 2019-02-28 16:05:58 UTC
A new version of the patch has been uploaded at ftp://ftp.openldap.org/incoming/nadezhda-ivanova-190228.patch

The patch has been integrated with master and tested.
It includes all the changes necessary to fix back-asyncmeta issues
discovered during on-site testing since the start of 2016.
These include:
Issues with stability - crashes and assertion failures
Incorrect behavior during unstable network conditions, such as inability to reset connections
or process responses, or "hanging" to wait for a response that would never be received.
Memory leaks and memory management fixes - major redesign of the way back-asyncmeta
works with memory contexts.
Rewrite was replaced with suffix-massage in configuration, and the network-timeout value was changed to milliseconds.
Incorrect behavior when SASL is used to bind to a target.
Many problems caused by race conditions
Fixes for compiler warnings, and tests.
Cleanup of unused code.

Nadezhda Ivanova

Software Engineer
Symas Corporation                       http://www.symas.com

Comment 3 Quanah Gibson-Mount 2019-02-28 16:22:51 UTC
--On Thursday, February 28, 2019 4:06 PM +0000 nivanova@symas.com wrote:

> A new version of the patch has been uploaded at
> ftp://ftp.openldap.org/incoming/nadezhda-ivanova-190228.patch

Thanks!  Applied to git master.

--Quanah


--

Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>


Comment 4 OpenLDAP project 2019-02-28 16:23:05 UTC
applied to master
Comment 5 Quanah Gibson-Mount 2019-02-28 16:23:05 UTC
changed notes
changed state Open to Test
moved from Incoming to Software Enhancements