Issue 630 - SASL result code
Summary: SASL result code
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2000-07-19 20:08 UTC by Mark Adamson
Modified: 2014-08-01 21:05 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Mark Adamson 2000-07-19 20:08:42 UTC
Looking at the new SASL code that is available in the 2.0 Beta tree. Looks
like a lot of good work was put into it.  I noticed was a result code from
the interact routine was not being checked correctly in

    libraries/libldap/cyrus.c


Here's the 10 cent patch, below.


-Mark Adamson
 Carnegie Mellon



---
./libraries/libldap/cyrus.c.old
Wed Jul 19 01:44:06 2000
+++ cyrus.c     Wed Jul 19 15:58:44 2000
@@ -578,7 +578,7 @@
                        if( saslrc == SASL_INTERACT ) {
                                int res;
                                if( !interact ) break;
-                               rc = (interact)( ld, flags, defaults, prompts );
+                               res = (interact)( ld, flags, defaults, prompts );
                                if( res != LDAP_SUCCESS ) {
                                        break;
                                }
 

Comment 1 Kurt Zeilenga 2000-07-19 20:56:07 UTC
Thanks... looks like the start interact checking is also slightly
flawed.  I'll commit a couple of changes in a bit.
	Kurt

Comment 2 Kurt Zeilenga 2000-07-20 10:09:07 UTC
moved from Incoming to Development
Comment 3 Kurt Zeilenga 2000-07-20 10:13:25 UTC
changed notes
changed state Open to Closed
Comment 4 OpenLDAP project 2014-08-01 21:05:27 UTC
fixed.