Issue 7054 - Please drop support to FreeBSD 1.x
Summary: Please drop support to FreeBSD 1.x
Status: VERIFIED SUSPENDED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: build (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-28 21:38 UTC by Xin Li
Modified: 2021-08-03 17:46 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Xin Li 2011-09-28 21:38:53 UTC
Full_Name: Xin Li
Version: git trunk
OS: FreeBSD/amd64 10.1
URL: http://pastebin.com/G8gpJs0r
Submission from: (NULL) (206.40.55.65)


Code duplicated from GNU libtool and autotools uses 'freebsd1*' rather than
'freebsd1.*' to test if the system is FreeBSD 1.x.  This logic would match
FreeBSD 10.0, causing problem when building shared libraries.

I'd like to propose that FreeBSD 1.x support be dropped since it's obsolete in
1994 (17 years ago).

The patch is just for reference, it also drops FreeBSD 2.x and FreeBSD 3.x
support but it's not complete.

A libtool patched with git revision e94c6d6e0359d92f08f491f57e0ef3371e978952
would also be required to build OpenLDAP properly.
Comment 1 Kurt Zeilenga 2011-09-29 01:26:32 UTC
Given the project doesn't specifically attempt to support FreeBSD 1.x, your request as summarized in the subject line is a bit odd.

I suggest this be considered more of a request to enable future support of the FreeBSD 10.x.

Do the current release of libtool and autotools includes the enabling features needed?

If so, then this can simply be treated as a request to update these tools (which are generally incorporated without any functional change).

If not, well, then we should just wait for thsoe enabling changes to be released by the upstream tool provider first…

Regards, Kurt

On Sep 28, 2011, at 2:38 PM, delphij@FreeBSD.org wrote:

> Full_Name: Xin Li
> Version: git trunk
> OS: FreeBSD/amd64 10.1
> URL: http://pastebin.com/G8gpJs0r
> Submission from: (NULL) (206.40.55.65)
> 
> 
> Code duplicated from GNU libtool and autotools uses 'freebsd1*' rather than
> 'freebsd1.*' to test if the system is FreeBSD 1.x.  This logic would match
> FreeBSD 10.0, causing problem when building shared libraries.
> 
> I'd like to propose that FreeBSD 1.x support be dropped since it's obsolete in
> 1994 (17 years ago).
> 
> The patch is just for reference, it also drops FreeBSD 2.x and FreeBSD 3.x
> support but it's not complete.
> 
> A libtool patched with git revision e94c6d6e0359d92f08f491f57e0ef3371e978952
> would also be required to build OpenLDAP properly.
> 


Comment 2 Howard Chu 2011-09-29 01:32:46 UTC
delphij@FreeBSD.org wrote:
> Full_Name: Xin Li
> Version: git trunk
> OS: FreeBSD/amd64 10.1
> URL: http://pastebin.com/G8gpJs0r
> Submission from: (NULL) (206.40.55.65)
>
>
> Code duplicated from GNU libtool and autotools uses 'freebsd1*' rather than
> 'freebsd1.*' to test if the system is FreeBSD 1.x.  This logic would match
> FreeBSD 10.0, causing problem when building shared libraries.
>
> I'd like to propose that FreeBSD 1.x support be dropped since it's obsolete in
> 1994 (17 years ago).

Probably a good idea. Thanks for the patch, but it's basically unusable.

Never submit patches to generated files. Only patch the source files. 
configure is generated from configure.in by autoconf. aclocal.m4 is also 
generated by autoconf; the section you patched appears to come from the 
libtool sources.

> The patch is just for reference, it also drops FreeBSD 2.x and FreeBSD 3.x
> support but it's not complete.
>
> A libtool patched with git revision e94c6d6e0359d92f08f491f57e0ef3371e978952
> would also be required to build OpenLDAP properly.
>
>


-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 3 Xin Li 2011-09-29 01:50:20 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi, Kurt,

On 09/28/11 18:26, Kurt Zeilenga wrote:
> Given the project doesn't specifically attempt to support FreeBSD
> 1.x, your request as summarized in the subject line is a bit odd.
> 
> I suggest this be considered more of a request to enable future
> support of the FreeBSD 10.x.
> 
> Do the current release of libtool and autotools includes the
> enabling features needed?
> 
> If so, then this can simply be treated as a request to update these
> tools (which are generally incorporated without any functional
> change).
> 
> If not, well, then we should just wait for thsoe enabling changes
> to be released by the upstream tool provider first…

I think we will have to wait for upstream release then, the changes
are already in their source tree.

I'll patch OpenLDAP in the FreeBSD ports to make it work at this moment.

> Regards, Kurt
> 
> On Sep 28, 2011, at 2:38 PM, delphij@FreeBSD.org wrote:
> 
>> Full_Name: Xin Li Version: git trunk OS: FreeBSD/amd64 10.1 URL:
>> http://pastebin.com/G8gpJs0r Submission from: (NULL)
>> (206.40.55.65)
>> 
>> 
>> Code duplicated from GNU libtool and autotools uses 'freebsd1*'
>> rather than 'freebsd1.*' to test if the system is FreeBSD 1.x.
>> This logic would match FreeBSD 10.0, causing problem when
>> building shared libraries.
>> 
>> I'd like to propose that FreeBSD 1.x support be dropped since
>> it's obsolete in 1994 (17 years ago).
>> 
>> The patch is just for reference, it also drops FreeBSD 2.x and
>> FreeBSD 3.x support but it's not complete.
>> 
>> A libtool patched with git revision
>> e94c6d6e0359d92f08f491f57e0ef3371e978952 would also be required
>> to build OpenLDAP properly.
>> 
> 


- -- 
Xin LI <delphij@delphij.net>	https://www.delphij.net/
FreeBSD - The Power to Serve!		Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iQEcBAEBCAAGBQJOg87cAAoJEATO+BI/yjfBfwIIAIjdABO2EUPVNpGLRrOqt20I
Yl5reH+OsBBwRTgjdDflZJcRA68fb5nsdsrRBheJA6oT0EJKWpPoW+uLjg84zx6s
TvGAifKMDJv6+v/PHpTkv2wO7nYIKXiS6D9415cJk3xMdEcDdRSXi+ppA+6IXGzV
fRL4rej0hoHNvgbXvowOL8F24rnnb6+r9fYYH773rwomL/+rYqZ1+iDbM4zs82d4
TSxOtjmfoEqUCyYJii3jo5CGs1LQ+Ndk16s7uwTArevba89GPVrNL3s/FxBLrEX+
Q8mBHaCkmsX1JuN7ZkYTJz7UvMJJO25IHDfEpjkM5aCqZvuy9nq7kflXxvuOASo=
=Wmav
-----END PGP SIGNATURE-----

Comment 4 Howard Chu 2011-09-30 10:08:45 UTC
changed state Open to Suspended
Comment 5 Xin Li 2011-10-24 18:18:08 UTC
Just a headsup -- libtool 2.4.2 should have the required changes to
support FreeBSD 10.x.

Cheers,
-- 
Xin LI <delphij@delphij.net>	https://www.delphij.net/
FreeBSD - The Power to Serve!		Live free or die

Comment 6 Hallvard Furuseth 2012-02-19 00:33:28 UTC
moved from Incoming to Build